Fix for z not retracting before moving home #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's happening is that since checkForStopCommand() is not called unless the machine is moving a stop sent when the machine is not running causes issues. The stop command (!) will sit in the buffer until a move command is sent. As soon as the move command is processed, the stop is detected and the line is not executed. The solution is to also check for the stop command when the machine is not moving.
|
good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's happening is that since checkForStopCommand() is not called unless the machine is moving. A stop stop sent when the machine is not running causes issues.
The stop command (!) will sit in the buffer until a move command is sent. As soon as the move command is processed, the stop is detected and the move command is not executed.
The solution is to also check for the stop command when the machine is not moving.